FluentValidation Issue Tracker Rss Feed

Commented Unassigned: How to validate the condition on dropdownloistfor in mvc razor [7144]

JeremyS — Fri, 10 May 2013 14:16:33 GMT

hi everybody,

int genderid;
selectlist genders;

html.dropdownlistfor ( genderid ,genders);

these are my three values in my drop down that i am unable to validate with fluent validation.

0 select
1 male
2 female

so can you please suggest me how to handle it.
Comments: Please could you provide more information - I'm going to need more than that to go on if you'd like me to help. What do you mean when you say that the values are "unable to validate"? Are you getting an error? How have you defined your validator?

Created Unassigned: How to validate the condition on dropdownloistfor in mvc razor [7144]

Anubhava — Fri, 10 May 2013 11:46:18 GMT

Edited Unassigned: ValidatorType Replace- RemoveRule [7143]

bobduncan — Wed, 08 May 2013 09:47:24 GMT

Commented Unassigned: ValidatorType Replace- RemoveRule [7143]

bobduncan — Wed, 08 May 2013 09:46:48 GMT

Commented Unassigned: ValidatorType Replace- RemoveRule [7143]

JeremyS — Wed, 08 May 2013 08:30:14 GMT

What type is the following validator:

RuleFor(x => x.Surname).Length(1, 140).Unless(MyUnlessMethod);

The Replace/RemoveRule methods needs a type, but when I supply it with typeof(LengthValidator) it doesn't work.

Basicly I want to be able to have a ruleset which specifies the length not to be 1 to 140but 1 to 70.
But in both cases and I need to be able to ignore the rule when the Unless case is met.

Comments: You wouldn't get two rules executed if you include them in separate rulesets, then explicitly choose which one you want to execute. See the documentation on named rulesets: https://fluentvalidation.codeplex.com/wikipage?title=CreatingAValidator&referringTitle=Documentation&ANCHOR#RuleSets

Commented Unassigned: ValidatorType Replace- RemoveRule [7143]

bobduncan — Wed, 08 May 2013 07:57:05 GMT

What type is the following validator:

RuleFor(x => x.Surname).Length(1, 140).Unless(MyUnlessMethod);

The Replace/RemoveRule methods needs a type, but when I supply it with typeof(LengthValidator) it doesn't work.

Basicly I want to be able to have a ruleset which specifies the length not to be 1 to 140but 1 to 70.
But in both cases and I need to be able to ignore the rule when the Unless case is met.

Comments: That would mean I would get two validation errors when I have an input string where it's length would be <70, while only the latest rule should be applied and the other one be ignored. Even though RemoveRule is used for a one-off modification, is there no other way to accomplice what I want to achieve?

Commented Unassigned: ValidatorType Replace- RemoveRule [7143]

JeremyS — Tue, 07 May 2013 12:54:08 GMT

What type is the following validator:

RuleFor(x => x.Surname).Length(1, 140).Unless(MyUnlessMethod);

The Replace/RemoveRule methods needs a type, but when I supply it with typeof(LengthValidator) it doesn't work.

Basicly I want to be able to have a ruleset which specifies the length not to be 1 to 140but 1 to 70.
But in both cases and I need to be able to ignore the rule when the Unless case is met.

Comments: Yes, so this is the correct behaviour - validator definitions are all built once when the validator is instantiated - you can't embed something like RemoveRule inside the validator's constructor as it will fire immediately as soon as the validator is instantiated. RemoveRule is used for a one-off modification of the rules after the validator has been instantiated. In your situation, it'd be better to define the rule twice in different rulesets rather than trying to use RemoveRule for this. Jeremy

Commented Unassigned: ValidatorType Replace- RemoveRule [7143]

bobduncan — Tue, 07 May 2013 11:43:13 GMT

Commented Unassigned: ValidatorType Replace- RemoveRule [7143]

JeremyS — Tue, 07 May 2013 09:06:40 GMT

Created Unassigned: ValidatorType Replace- RemoveRule [7143]

bobduncan — Mon, 06 May 2013 09:11:07 GMT

Commented Issue: Make inheritance of FluentValidationModelValidatorProvider useful [7134]

fsateler — Mon, 29 Apr 2013 23:19:27 GMT

Hi Jeremy,

The FluentValidationModelValidatorProvider integration with MVC is very useful. However, if one would like to override some parts of the class it is not possible since the only overridable function is GetValidators.

In particular, it would be interesting to be able to access the (currently) private method IsValidatingProperty and create a new method that invokes the validator factory, which can be overriden.

Rationale: The type passed to the validator factory may not be always correct in order to make the best decision for a validator. In other words, ModelMetadata.ContainerType or ModelMetadata.ModelType (depending on wether a property or the model is being validated) may not be the correct type to use.

For example, suppose the following form models:

```
class F1 {
int Property {get; set;}
}

class F2 : F1 {
int Another { get; set; }
}
```

Each with its own validator. Now suppose I have a partial view that renders the appropriate way to select Property (involving a `TextBoxFor(f => f.Property)`, and it is strongly typed to F1. This partial will be called from a strongly typed view of F2.

In this scenario, when the `TextBoxFor(f => f.Property)` is rendered, the ModelMetadata.ContainerType will be F1 instead of F2, thus rendering the wrong unobtrusive validations.

Summary: an overridable function that determines which type to pass to the validator factory would be nice to have in the Provider.

The following code should provide everything needed.

````
public virtual IValidator InvokeValidatorFactory(ModelMetadata metadata,
ControllerContext context) {
if (IsValidatingProperty(metadata)) {
return ValidatorFactory.GetValidator(metadata.ContainerType);
}
return ValidatorFactory.GetValidator(metadata.ModelType);
}
public override IEnumerable<ModelValidator> GetValidators(ModelMetadata metadata,
ControllerContext context) {
IValidator validator = InvokeValidatorFactory(metadata, context);
if (IsValidatingProperty(metadata)) {
return GetValidatorsForProperty(metadata, context, validator);
}
return GetValidatorsForModel(metadata, context, validator);
}
````
Comments: Just for the record, the current FluentValidation 4.0 fixes this problem for me. Thanks for your work in this!

Closed Unassigned: SetValidator with When not work valid in MVC 4 [7142]

JeremyS — Mon, 29 Apr 2013 12:43:06 GMT

Commented Unassigned: SetValidator with When not work valid in MVC 4 [7142]

JeremyS — Mon, 29 Apr 2013 12:43:00 GMT

Commented Unassigned: SetValidator with When not work valid in MVC 4 [7142]

wojtpl2 — Mon, 29 Apr 2013 12:09:09 GMT

Commented Unassigned: SetValidator with When not work valid in MVC 4 [7142]

wojtpl2 — Mon, 29 Apr 2013 12:04:08 GMT

I have models and validators:

```
[Validator(typeof(AdressValidator))]
public class Adress {
public string PostalCode { get; set; }
public string Street { get; set; }
}

[Validator(typeof(PersonValidator))]
public class Person
{
public Adress Adress { get; set; }
public bool IsAdress2 { get; set; }
public Adress Adress2 { get; set; }
}

public class AdressValidator : AbstractValidator<Adress> {
public AdressValidator() {
RuleFor(p => p.PostalCode).NotEmpty();
RuleFor(p => p.Street).NotEmpty();
}
}

public class PersonValidator : AbstractValidator<Person>
{
public PersonValidator()
{
RuleFor(p => p.Adress).SetValidator(new AdressValidator());
RuleFor(p => p.Adress2).SetValidator(new AdressValidator()).When(p=>p.IsAdress2);
}
}
```

And controlers:
```
public class HomeController : Controller
{
//
// GET: /Home/

public ActionResult Index() {
Person person = new Person() {
Adress = new Adress() {
PostalCode = "12-100",
Street = "Street 13"
},
IsAdress2 = false,
Adress2 = new Adress()
};

return View(person);
}

[HttpPost]
public ActionResult Index(Person person)
{
if (ModelState.IsValid) {
return RedirectToAction("OK");
}
return View(person);
}

public ActionResult Ok() {
return View();
}
}
```

Adress2 is always validated.

In Attachments is solution without lib and packages.
Comments: ``` public class NotAssemblyScanner : Attribute { } ``` in AssemblyScanner: ``` private IEnumerable<AssemblyScanResult> Execute() { var openGenericType = typeof(IValidator<>); var query = from type in types let interfaces = type.GetInterfaces() let genericInterfaces = interfaces.Where(i => i.IsGenericType && i.GetGenericTypeDefinition() == openGenericType) let matchingInterface = genericInterfaces.FirstOrDefault() where matchingInterface != null __&& !type.GetCustomAttributes(typeof(NotAssemblyScanner), false).Any()__ select new AssemblyScanResult(matchingInterface, type); return query; } ``` in AssenblyScannerTest: #region License // Copyright (c) Jeremy Skinner (http://www.jeremyskinner.co.uk) // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. // // The latest version of this file can be found at http://www.codeplex.com/FluentValidation #endregion namespace FluentValidation.Tests { using System.Collections.Generic; using System.Linq; using NUnit.Framework; [TestFixture] public class AssemblyScannerTester { [Test] public void Finds_validators_for_types() { var scanner = new AssemblyScanner(new[] { typeof(Model1Validator), typeof(Model2Validator)__, typeof(Model3Validator)__ }); var results = scanner.ToList(); results[0].ValidatorType.ShouldEqual(typeof(Model1Validator)); results[0].InterfaceType.ShouldEqual(typeof(IValidator<Model1>)); results[1].ValidatorType.ShouldEqual(typeof(Model2Validator)); results[1].InterfaceType.ShouldEqual(typeof(IValidator<Model2>)); __ results.Count.ShouldEqual(2);__ } [Test] public void ForEach_iterates_over_types() { var scanner = new AssemblyScanner(new[] { typeof(Model1Validator), typeof(Model2Validator)__, typeof(Model3Validator)__ }); var results = new List<AssemblyScanner.AssemblyScanResult>(); scanner.ForEach(x => results.Add(x)); results.Count.ShouldEqual(2); } public class Model1 { } public class Model2 { } __ public class Model3 { } public class Model1Validator:AbstractValidator<Model1> { } public class Model2Validator:AbstractValidator<Model2> { } [NotAssemblyScanner] public class Model3Validator : AbstractValidator<Model2> { } }__ }

Commented Unassigned: SetValidator with When not work valid in MVC 4 [7142]

wojtpl2 — Mon, 29 Apr 2013 11:49:32 GMT

Commented Unassigned: SetValidator with When not work valid in MVC 4 [7142]

JeremyS — Mon, 29 Apr 2013 10:41:08 GMT

Commented Unassigned: SetValidator with When not work valid in MVC 4 [7142]

wojtpl2 — Mon, 29 Apr 2013 10:21:55 GMT

Commented Unassigned: SetValidator with When not work valid in MVC 4 [7142]

JeremyS — Mon, 29 Apr 2013 09:07:45 GMT

Commented Unassigned: SetValidator with When not work valid in MVC 4 [7142]

wojtpl2 — Mon, 29 Apr 2013 06:37:37 GMT